[vm] upgrade move coverage tool #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wrong address format (0x0x...) caused by starcoin change of fmt::Display for AccountAddress. The change is applied for specific sdk reason. Currently there is no plan to fix it so we have the work around above. |
jolestar
reviewed
Nov 19, 2020
vm/move-coverage/src/coverage_map.rs
Outdated
| pub fn output_map_to_file<M: Serialize, P: AsRef<Path>>(file_name: P, data: &M) -> Result<()> { | ||
| let bytes = scs::to_bytes(data)?; | ||
| let mut file = File::create(file_name)?; | ||
| file.write_all(&bytes)?; | ||
| Ok(()) | ||
| } | ||
|
|
||
| pub fn preprocess_address(literal: &str) -> &str { | ||
| if literal.starts_with("0x0x") { |
There was a problem hiding this comment.
这是哪里序列化 address 的时候手动拼接了一个 0x？
There was a problem hiding this comment.
There was a problem hiding this comment.
确认了一下，这个是统一地址格式时有些地方没有完全覆盖到，已经在libra这边处理了。
jolestar
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.